chore: Disable abs and signum because they return incorrect results #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=============================================
+ Coverage 33.63% 53.66% +20.02%
+ Complexity 821 810 -11
=============================================
Files 109 107 -2
Lines 42529 10266 -32263
Branches 9343 1929 -7414
=============================================
- Hits 14304 5509 -8795
+ Misses 25262 3782 -21480
+ Partials 2963 975 -1988 ☔ View full report in Codecov by Sentry. |
viirya
approved these changes
Jul 20, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #666
Related to #664
Rationale for this change
We are preparing to create the first release candidate, so I wanted to make sure we removed the expressions that are not implemented correctly (from a Spark compatibility viewpoint).
What changes are included in this PR?
Disable abs and signum.
How are these changes tested?